[Flang] Change sizeof argument name to "x" #130189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llvmbot
added
flang
Member
|
@llvm/pr-subscribers-flang-semantics Author: Andre Kuhlenschmidt (akuhlens) ChangesThis closes #128610 by fixing the name of the argument to the sizeof function to be "x" and adds a test. Full diff: https://github.com/llvm/llvm-project/pull/130189.diff 2 Files Affected:
diff --git a/flang/lib/Evaluate/intrinsics.cpp b/flang/lib/Evaluate/intrinsics.cpp
index fe691e85ee011..65f17f06667dd 100644
--- a/flang/lib/Evaluate/intrinsics.cpp
+++ b/flang/lib/Evaluate/intrinsics.cpp
@@ -936,7 +936,7 @@ static const IntrinsicInterface genericIntrinsicFunction[]{
OptionalDIM, // unless array is assumed-size
SizeDefaultKIND},
KINDInt, Rank::scalar, IntrinsicClass::inquiryFunction},
- {"sizeof", {{"a", AnyData, Rank::anyOrAssumedRank}}, SubscriptInt,
+ {"sizeof", {{"x", AnyData, Rank::anyOrAssumedRank}}, SubscriptInt,
Rank::scalar, IntrinsicClass::inquiryFunction},
{"spacing", {{"x", SameReal}}, SameReal},
{"spread",
diff --git a/flang/test/Intrinsics/sizeof.f90 b/flang/test/Intrinsics/sizeof.f90
new file mode 100644
index 0000000000000..c7bd9788a3ce4
--- /dev/null
+++ b/flang/test/Intrinsics/sizeof.f90
@@ -0,0 +1,10 @@
+! RUN: %python %S/test_errors.py %s %flang_fc1
+ character(len=20) :: a, b
+ if (sizeof(a) == sizeof(x=b)) then
+ print *, "pass"
+ else
+ print *, "fail"
+ end if
+ ERROR! unknown keyword argument to intrinsic 'sizeof'
+ print *, sizeof(a=a)
+end
\ No newline at end of file
|
klausler
reviewed
Mar 6, 2025
Contributor
|
I reviewed and don't have any other comments. I'll defer to Peter to approve this. |
klausler
approved these changes
Mar 7, 2025
eugeneepshteyn
approved these changes
Mar 10, 2025
akuhlens
force-pushed
the
andre/gh-128610
branch
from
cd49f78 to
166abcc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #128610 by fixing the name of the argument to the sizeof function to be "x" and adds a test.